Fix issue #573 - optable listing for optable(ZS3) should match HLASM #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyganci
reviewed
Nov 25, 2024
| @@ -2124,11 +2154,11 @@ else if (tz390.op_trace_type[index]==343) | |||
| case 36: | |||
| // Alternate formats have mnemonics ending in 'A' | |||
| if (my_mnemonic.substring(my_mnemonic.length()-1).equals("A")) // #500 | |||
| {my_format="RRF"; // #500 | |||
| {my_format="RRF"; // #500 #573 | |||
There was a problem hiding this comment.
Looks the same as the previous line??? Does not appear to be changing anything, but okay.
jyganci
approved these changes
Nov 25, 2024
jyganci
reviewed
Dec 30, 2024
| @@ -116,6 +148,7 @@ call rt\bat\RUNOPTABLE %z_TraceMode% optable UNI *None | |||
| set z_ReturnCode=%ERRORLEVEL% | |||
| if %z_ReturnCode% EQU 0 (set /A count_ok=%count_ok%+1) else ( | |||
| set /A count_err=%count_err%+1 | |||
| set err_optable=%err_optable% uni | |||
There was a problem hiding this comment.
Suggestion only. For consistency, change uni to UNI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #573 - optable listing for optable(ZS3) should match HLASM